Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement admin edit user privilege #115

Merged
merged 10 commits into from
Sep 27, 2024

Conversation

jq1836
Copy link

@jq1836 jq1836 commented Sep 23, 2024

Resolves #21
Review after #114

Overview

Add in feature to allow admin users to give/remove admin privileges to other users.

Changelog

  • Added update-user-privilege.ts
  • Added Switch UI component for isAdmin field
  • Updated incorrect endpoint in user-service/README.md

@jq1836 jq1836 self-assigned this Sep 23, 2024
@jq1836 jq1836 changed the base branch from feature/user-service/admin-edit-user to main September 23, 2024 09:53
Copy link

@wr1159 wr1159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's alright code wise but the switch component looks really weird on my screen, the thumb is very hard to see
image
image

Copy link

@wr1159 wr1159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jq1836 jq1836 changed the base branch from main to chore/add-user-interface September 27, 2024 08:28
@jq1836 jq1836 changed the base branch from chore/add-user-interface to main September 27, 2024 08:28
@jq1836 jq1836 merged commit 710f1f1 into main Sep 27, 2024
1 check passed
@jq1836 jq1836 deleted the feature/user-service/admin-update-privilege branch September 27, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F1.4.1 The service shall allow admin users to update the roles of all users between admin and non-admin.
2 participants