Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#196] Integrate collaboration service into deployment #198

Merged
merged 5 commits into from
Nov 6, 2024
Merged

[#196] Integrate collaboration service into deployment #198

merged 5 commits into from
Nov 6, 2024

Conversation

glemenneo
Copy link

@glemenneo glemenneo commented Nov 6, 2024 •
edited
Loading

  • Change websocket port to be environment variable
  • Change Nginx to proxy pass for websocket connections
  • Change FE websocket urls to match Nginx proxy pass

@glemenneo glemenneo added the enhancement New feature or request label Nov 6, 2024
@glemenneo glemenneo self-assigned this Nov 6, 2024
@glemenneo glemenneo linked an issue Nov 6, 2024 that may be closed by this pull request
[BE] Integrate collaboration service into deployment #196
Closed
3 tasks
@glemenneo glemenneo marked this pull request as ready for review November 6, 2024 03:59
shishirbychapur
shishirbychapur approved these changes Nov 6, 2024
View reviewed changes
Copy link

@shishirbychapur shishirbychapur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@glemenneo glemenneo merged commit 3b2d1c8 into main Nov 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shishirbychapur shishirbychapur shishirbychapur approved these changes

@Daviancold Daviancold Awaiting requested review from Daviancold Daviancold is a code owner

@lynnlow175 lynnlow175 Awaiting requested review from lynnlow175 lynnlow175 is a code owner

@yunruu yunruu Awaiting requested review from yunruu yunruu is a code owner

Assignees

@glemenneo glemenneo

Labels
enhancement New feature or request
Projects
None yet
Milestone
Milestone D5: Integration and Collabo...
Development

Successfully merging this pull request may close these issues.

[BE] Integrate collaboration service into deployment
2 participants
@glemenneo @shishirbychapur