Add N5 and fully implement question integration to collab service #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mahidharah
commented
Nov 6, 2024
Mahidharah
commented
- Implement genAI prompting on the backend
- Fix question service functions to return mongodbID instead of question title
- Update model to include mongoose Object as a parameter
- Update routing to collab to be neater
- Update collabUI to fetch question from question service before displaying question details
…tails from the backend correctly
|
Frontend URL: |
sp4ce-cowboy
approved these changes
Nov 6, 2024
| @@ -907,6 +907,15 @@ asynckit@^0.4.0: | |||
| resolved "https://registry.npmjs.org/asynckit/-/asynckit-0.4.0.tgz" | |||
| integrity sha512-Oei9OH4tRh0YqU3GxhX79dM/mwVgvbZJaSNaRk+bshkj0S5cfHcgYakreBjrHwatXKbz+IoIdYLxrKim2MjW0Q== | |||
|
|
|||
| axios@^1.7.7: | |||
There was a problem hiding this comment.
Good idea to use axios v1.7.7 here
| @@ -52,7 +52,7 @@ const App: React.FC = () => { | |||
| <Route path="/collab" element={<CollaborationServiceView topic={''} difficulty={''} sessionId={''} />} /> | |||
|
|
|||
| {/* Public Route for Collaboration Service Integrated View */} | |||
| <Route path="/collabFull/:topic/:difficulty/:questionId/:sessionId" element={<CollaborationServiceIntegratedView />} /> | |||
There was a problem hiding this comment.
Good choice, it wasn't feasible to have the difficulty and topic in the url
| }; | ||
|
|
||
| export const getQuestionById = async (id: string): Promise<Question> => { |
There was a problem hiding this comment.
Great idea to return a Question object asynchronously instead of just the string
|
|
||
|
|
||
| const CollaborationServiceIntegratedView: React.FC = () => { | ||
| const { topic, difficulty, questionId, sessionId } = useParams<{ topic: string; difficulty: string; questionId: string; sessionId: string; }>(); |
| @@ -41,12 +78,12 @@ const CollaborationServiceIntegratedView: React.FC = () => { | |||
| }; | |||
|
|
|||
| useEffect(() => { | |||
| console.log(`Session ID: ${sessionId}, Topic: ${topic}, Difficulty: ${difficulty}`); | |||
| console.log(`Session ID: ${sessionId}, Topics: ${topics}, Difficulty: ${difficulty}`); | |||
| <h2>Collaboration Session</h2> | ||
| <p>Topic: {topic} | Difficulty: {difficulty} | Session: {sessionId}</p> | ||
| <p>Question: {questionId}</p> | ||
| <h3>Collaboration Session</h3> |
There was a problem hiding this comment.
Good idea to change the Collab Session title to h3, h2 was a bit too big anyway
| @@ -75,7 +75,8 @@ const MatchingServiceMainView: React.FC = () => { | |||
| console.log(data.message); | |||
| setMatchFound(true); // Set match status to true | |||
| stopProgressBar(); | |||
| setStatusMessage(`Match found for ${topic} and ${difficulty}!`); | |||
| //setStatusMessage(`Match found for ${topic} and ${difficulty}!`); | |||
There was a problem hiding this comment.
Just a nit, might want to remove this. But LGTM otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.