Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix interview bug #79

Merged
merged 1 commit into from
Oct 30, 2023
Merged

fix interview bug #79

merged 1 commit into from
Oct 30, 2023

Conversation

Wong-Jia-Jun
Copy link
Contributor

close interviewerView when changing role

@Wong-Jia-Jun
fix interview bug
421db9c 
close interviewerview when changing role
bokuanT
bokuanT approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@bokuanT bokuanT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bokuanT bokuanT merged commit 3222e48 into CS3219-AY2324S1:master Oct 30, 2023
6 of 7 checks passed
@Wong-Jia-Jun Wong-Jia-Jun linked an issue Nov 7, 2023 that may be closed by this pull request
When interviewer role is switched, interviewer view remains open for non-interviewer #65
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bokuanT bokuanT bokuanT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When interviewer role is switched, interviewer view remains open for non-interviewer
2 participants
@Wong-Jia-Jun @bokuanT