Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix toast at wrong location #110

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Fix toast at wrong location #110

merged 6 commits into from
Nov 14, 2023

Conversation

Gabau
Copy link
Contributor

@Gabau Gabau commented Nov 13, 2023 •
edited
Loading

  • Also fixes bug where stale data affects ui

@Gabau Gabau marked this pull request as ready for review November 13, 2023 14:59
@Gabau Gabau requested review from kflim and samyipsh November 13, 2023 16:10
kflim
kflim approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@kflim kflim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work, LGTM

samyipsh
samyipsh approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@samyipsh samyipsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Gabau Gabau merged commit 516c266 into master Nov 14, 2023
2 checks passed
@Gabau Gabau deleted the gabau/fix-toast branch November 14, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samyipsh samyipsh samyipsh approved these changes

@kflim kflim kflim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gabau @kflim @samyipsh