-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch bound constructors #85
Conversation
ffedb56
to
e4f53a7
Compare
Actually when thinking about it, this should not be patched in the enzymes function (this one just forwards the stuff transparently, which is all OK), but in the code that uses it. In particular, one should do e.g. enzyme_constraints(
...,
capacity_limits = [(:something, somefluxes, BetweenT{MyWeirdType}(0, somevariable))]
) |
/format |
✔️ Auto-formatting triggered by this comment succeeded, commited as a1d8658 |
@stelmo I decided to do this properly, pls review Might be the case that I need to add some tests still, will do later |
4f7d366
to
1ea118f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #85 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 38 38
Lines 573 579 +6
=========================================
+ Hits 573 579 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hopefully ok now, need to fix the tests
The last 3 hours wasted on this simple issue prove that we need an actual type system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh finally 🤯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. release 🦀 ?
No description provided.