Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for loading the coupling bounds from FBC #41

Merged
merged 7 commits into from
Jun 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
with:
version: ${{ matrix.version }}
arch: ${{ matrix.arch }}
- uses: julia-actions/cache@v1
- uses: julia-actions/cache@v2
- uses: julia-actions/julia-buildpkg@latest
- run: |
git config --global user.name Tester
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- uses: julia-actions/setup-julia@latest
with:
version: '1.9'
- uses: julia-actions/cache@v1
- uses: julia-actions/cache@v2
- name: Install dependencies
run: julia --color=yes --project=docs/ -e 'using Pkg; Pkg.develop(PackageSpec(path=pwd())); Pkg.instantiate()'
- name: Build and deploy
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
StableRNGs = "860ef19b-820b-49d6-a774-d7a799459cd3"

[compat]
AbstractFBCModels = "0.2.2"
AbstractFBCModels = "0.3"
Aqua = "0.7"
Clarabel = "0.6"
ConstraintTrees = "1.1"
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
[docs-img-dev]: https://img.shields.io/badge/docs-latest-0af.svg
[docs-url-dev]: https://cobrexa.github.io/COBREXA.jl/dev/
[docs-url-examples]: https://cobrexa.github.io/COBREXA.jl/dev/examples/
[docs-url-fba]: https://cobrexa.github.io/COBREXA.jl/dev/examples/02-flux-balance-analysis/
[docs-url-fba]: https://cobrexa.github.io/COBREXA.jl/dev/examples/02a-flux-balance-analysis/

[docker-url]: https://github.com/COBREXA/COBREXA.jl/pkgs/container/cobrexa.jl
[docker-img]: https://ghcr-badge.egpl.dev/cobrexa/cobrexa.jl/size?color=%2362a0ea&tag=latest&label=docker&trim=
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
# disadvantage is that the "common" FBC model interface does not easily express
# various complicated constructions (communities, reaction coupling, enzyme
# constraints, etc.) -- see the [example about modifying the
# constraints](02c-constraint-modifications.md) for more details.
# constraints](02d-constraint-modifications.md) for more details.
#
# ## Getting the base model

Expand Down Expand Up @@ -166,4 +166,28 @@ flux_changes =
sort(collect(flux_changes), by = last)

#md # !!! tip "Always use a uniquely defined flux solutions for flux comparisons"
#md # Since the usual flux balance allows a lot of freedom in the "solved" flux and the only value that is "reproducible" by the analysis is the objective, one should never compare the flux distributions directly. Typically, that may result in false-positive (and sometimes false-negative) differences. Use e.g. [parsimonious FBA](03-parsimonious-flux-balance.md) to obtain uniquely determined and safely comparable flux solutions.
#md # Since the usual flux balance allows a lot of freedom in the "solved" flux and the only value that is "reproducible" by the analysis is the objective, one should never compare the flux distributions directly. Typically, that may result in false-positive (and sometimes false-negative) differences. Use e.g. [parsimonious FBA](03b-parsimonious-flux-balance.md) to obtain uniquely determined and safely comparable flux solutions.

# ## Coupling constraints
#
# Some model types support additional constraints over the reaction fluxes,
# which are historically called "coupling". These allow to e.g. place a bound
# on a total flux through several reactions.
#
# Canonical model supports these as "couplings":

model.couplings["total_energy_intake"] = CM.Coupling(
lower_bound = 0,
upper_bound = 5,
reaction_weights = Dict("EX_glc__D_e" => -1.0, "EX_fru_e" => -1.0, "EX_pyr_e" => -1.0),
)

# The values of any coupling constraints can be inspected directly in the
# solved model:

solution_with_coupling = flux_balance_analysis(model, optimizer = GLPK.Optimizer)

solution_with_coupling.coupling.total_energy_intake

@test 0 <= solution_with_coupling.coupling.total_energy_intake <= 5 #src
@test isapprox(solution_with_coupling.objective, 0.4155977750928965, atol = TEST_TOLERANCE) #src
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# # Making adjustments to the constraint system
#
# In the [previous example about model
# adjustments](02b-model-modifications.md), we noted that some constraint
# adjustments](02c-model-modifications.md), we noted that some constraint
# systems may be too complex to be changed within the limits of the usual FBC
# model view, and we may require a sharper tool to do the changes we need. This
# example shows how to do that by modifying the constraint systems that are
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
11 changes: 11 additions & 0 deletions src/frontend/balance.jl
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ function flux_balance_constraints(
stoi = A.stoichiometry(model)
bal = A.balance(model)
obj = A.objective(model)
cpls = Symbol.(A.couplings(model))
cT = SparseArrays.SparseMatrixCSC(A.coupling(model)')
clbs, cubs = A.coupling_bounds(model)

# The iteration through stoichiometry would be better done with eachrow(),
# unfortunately it seems to be enormously inefficient on column-major
Expand All @@ -70,6 +73,14 @@ function flux_balance_constraints(
bound = C.EqualTo(b),
) for (met, row_idx, b) in zip(mets, 1:stoiT.n, bal)
) *
:coupling^C.ConstraintTree(
cpl => C.Constraint(
value = let i = cT.colptr[row_idx], e = cT.colptr[row_idx+1] - 1
C.LinearValue(idxs = cT.rowval[i:e], weights = cT.nzval[i:e])
end,
bound = clb == cub ? C.EqualTo(clb) : C.Between(clb, cub),
) for (cpl, row_idx, clb, cub) in zip(cpls, 1:cT.n, clbs, cubs)
) *
:objective^C.Constraint(C.LinearValue(SparseArrays.sparse(obj))),
)

Expand Down
Loading