-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WNMGDS-3160] Updates docs site color guidance #3395
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! In a perfect world there'd be a way for Andrea or I to be able to edit the content (specifically "used in") without triggering a whole release process but either way this is a vast improvement over the existing.
Also I know I owe you the feedback link still!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
This work can also be reviewed at https://cmsgov.github.io/design-system/branch/kcn/3160/update-color-guidance/foundation/theme-colors/?theme=core
@sophia-cmsds and @andream-cmsds I'm particularly interested in addressing any feedback you might have! We can talk more about ways to define specific commentary about each color category. You'll find it's generic now, but that can be addressed.
How to test
Checklist
[WNMGDS-####] Title
or [NO-TICKET] if this is unticketed work.Type
(only one) label for this PR, if it is a breaking change, label should only beType: Breaking
Impacts
, multiple can be selected.If this is a change to documentation: