Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

[Py2Py3] Migrate module Unified/batchor #1091

Merged
merged 3 commits into from
Nov 9, 2022

Conversation

haozturk
Copy link
Collaborator

@haozturk haozturk commented Nov 9, 2022

Fixes #1090

Status

ready

Description

[Py2Py3] Migrate module Unified/batchor

BASE_DIR=/data/unifiedPy3-fast/WmAgentScripts
HTML_DIR=/var/www/html/unified/

lock_name=`echo $BASH_SOURCE | cut -f 1 -d "."`.lock
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck] reported by reviewdog 🐶
Use $(...) notation instead of legacy backticks .... SC2006

BASE_DIR=/data/unifiedPy3-fast/WmAgentScripts
HTML_DIR=/var/www/html/unified/

lock_name=`echo $BASH_SOURCE | cut -f 1 -d "."`.lock
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [shellcheck] reported by reviewdog 🐶
Expanding an array without an index only gives the first element. SC2128

BASE_DIR=/data/unifiedPy3-fast/WmAgentScripts
HTML_DIR=/var/www/html/unified/

lock_name=`echo $BASH_SOURCE | cut -f 1 -d "."`.lock
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

HTML_DIR=/var/www/html/unified/

lock_name=`echo $BASH_SOURCE | cut -f 1 -d "."`.lock
source $BASE_DIR/cycle_common.sh $lock_name
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

source $BASE_DIR/cycle_common.sh $lock_name

## Set up the environment
source /data/unifiedPy3-fast/setEnv.sh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Not following: /data/unifiedPy3-fast/setEnv.sh: openBinaryFile: does not exist (No such file or directory) SC1091

## submit ACDCs and clones from actions submitted via new recovery tools
$BASE_DIR/cWrap.sh Unified/batchor.py

rm -f $lock_name
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

@haozturk haozturk merged commit 5083b17 into python3-migration-fast Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant