Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] removed .gitmodules #1311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mdjou
Copy link

@mdjou mdjou commented Apr 2, 2024

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide. not present at this time
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used the project.
  • I have used the project briefly.
  • I have used the project extensively, but have not contributed previously.
  • I am an active contributor to the project.

If the project maintainer has any additional requirements, they will be listed here.

  • No additional requirements.

I noticed that this repo has a .gitmodules file, but it doesn't use the submodule defined in it, and the addon_common folder is just a regular folder in the repository. This is only a minor annoyance, but here's a PR removing it.

@vxlcoder
Copy link
Contributor

vxlcoder commented Apr 2, 2024

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants