Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextFormField separator removal #170

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

RohanSengupta326
Copy link

Fixes #158

Describe the changes you have made in this PR -

  • Removed the separator between TextFormFields and inserted UnderlineInputBorder in both Existing and New Account Screen

Screenshots of the changes (If any) -

Screenshot 2022-10-13 at 4 13 20 PM
Screenshot 2022-10-13 at 4 13 28 PM

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@ItsAdityaKSingh
Copy link
Collaborator

Hey @RohanSengupta326! I guess it could be better to reduce and align the underline properly.

@RohanSengupta326
Copy link
Author

how about this? @ItsAdityaKSingh

Screenshot 2022-10-15 at 1 07 07 PM

Screenshot 2022-10-15 at 1 07 07 PM

@ItsAdityaKSingh
Copy link
Collaborator

Better! Try to move that eye icon away from the underline. It should not look to be in the text field.

@RohanSengupta326
Copy link
Author

RohanSengupta326 commented Oct 16, 2022

@ItsAdityaKSingh

Screenshot 2022-10-16 at 2 08 00 PM

Screenshot 2022-10-16 at 2 08 51 PM

@ItsAdityaKSingh
Copy link
Collaborator

That's great! Could you also just push the eye icon up a little so that it comes above the underline horizontal space?

@RohanSengupta326
Copy link
Author

Is this height of the eye icon okay or is more needed? @ItsAdityaKSingh

Screenshot 2022-10-16 at 2 43 11 PM
Screenshot 2022-10-16 at 2 43 21 PM

@ItsAdityaKSingh
Copy link
Collaborator

ItsAdityaKSingh commented Oct 16, 2022

LGTM! @nb9960, could you review?

@RohanSengupta326
Copy link
Author

so should send the PR now or wait? @ItsAdityaKSingh

Copy link
Collaborator

@nb9960 nb9960 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why debug.keystore file is introduced?

@@ -381,12 +422,12 @@ class _AuthScreenState extends State<AuthScreen>
),
),
),
separator(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think separator widget is being used anywhere now, can you please remove the widget (wherever it is declared) too

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure.

@RohanSengupta326
Copy link
Author

RohanSengupta326 commented Oct 18, 2022

@nb9960

debug.keystore and pubspec.lock were changed automatically.
I reverted the changes and committed including the UI changes.
and also removed the separator widget as you asked.
please check.

@ItsAdityaKSingh
Copy link
Collaborator

Hey @RohanSengupta326, could you please see PR #175 and discuss the need for separate cards for the fields or have the fields on the same card? You could look at the UI and suggest your ideas there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

This line is misleading as a text field
3 participants