Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Nextgen/BetterTab) #5077

Merged
merged 4 commits into from
Dec 29, 2024
Merged

feat(Nextgen/BetterTab) #5077

merged 4 commits into from
Dec 29, 2024

Conversation

sqlerrorthing
Copy link
Contributor

@sqlerrorthing sqlerrorthing commented Dec 28, 2024 •
edited
Loading

Features (in tablist):

  • More limits control:
    • 1 <= TabSize <= 1000
    • 1 <= ColumnHeight <= 1000
  • Highlight (with color customization)
    • Self
    • Friends
  • Accurate latency (numerical latency)
  • Visibility
    • Header
    • Footer
  • Sorting
    • Vanilla
    • Ping (less -> more)
    • NameLength (min -> max)
    • Alphabetical
    • ReverseAlphabetical
    • None

@ccetl
Copy link
Contributor

ccetl commented Dec 28, 2024 •
edited
Loading

Rather name your PRs after the following pattern: <type>[optional scope]: <description>.
You don't have to mention nextgen as it's the main branch.

ccetl
ccetl reviewed Dec 29, 2024
View reviewed changes
Copy link
Contributor

@ccetl ccetl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove accurate latency? It's a great feature.
Opps looked at the wrong diff, everything is alright now. 👍

1zun4
1zun4 approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@1zun4 1zun4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@1zun4 1zun4 added this to the 0.23.0 milestone Dec 29, 2024
@1zun4
Copy link
Member

1zun4 commented Dec 29, 2024

image

@1zun4 1zun4 merged commit 8f7e039 into CCBlueX:nextgen Dec 29, 2024
3 checks passed
@sqlerrorthing sqlerrorthing deleted the better-tab branch December 29, 2024 09:15
@1zun4 1zun4 mentioned this pull request Dec 29, 2024
Closed
commandblock2 pushed a commit to commandblock2/LiquidBounce that referenced this pull request Dec 31, 2024
@sqlerrorthing @commandblock2
feat: Better Tab (CCBlueX#5077)
2821033 
Features (in tablist):
* More limits control:
  * 1 <= TabSize <= 1000
  * 1 <= ColumnHeight <= 1000
* Highlight  (with color customization)
  * Self
  * Friends
* Accurate latency (numerical latency)
* Visibility
  * Header
  * Footer
* Sorting
  * Vanilla
  * Ping (less -> more)
  * NameLength (min -> max)
  * Alphabetical
  * ReverseAlphabetical
  * None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccetl ccetl ccetl left review comments

@1zun4 1zun4 1zun4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sqlerrorthing @ccetl @1zun4