feat(Nextgen/BookBot) #5076
Open
feat(Nextgen/BookBot) #5076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The module is missing a module description. |
1zun4
reviewed
Dec 29, 2024
src/main/kotlin/net/ccbluex/liquidbounce/features/module/modules/player/invcleaner/ItemSlot.kt
Outdated
Show resolved
Hide resolved
1zun4
reviewed
Dec 29, 2024
src/main/kotlin/net/ccbluex/liquidbounce/features/module/modules/misc/ModuleBookBot.kt
Outdated
Show resolved
Hide resolved
1zun4
reviewed
Dec 29, 2024
Comment on lines
62
to
70
| val book = findInventorySlot { | ||
| val component = it.get(DataComponentTypes.WRITABLE_BOOK_CONTENT) ?: return@findInventorySlot false | ||
| return@findInventorySlot it.item == Items.WRITABLE_BOOK && component.pages.isEmpty() | ||
| } ?: run { | ||
| enabled = false | ||
| return@tickHandler | ||
| } | ||
|
|
||
| book.performSwap(to = HotbarItemSlot(player.inventory.selectedSlot)).performAction() |
There was a problem hiding this comment.
We should use ScheduleInventoryActionEvent for cases like this and allow to put inventory constraints.
1zun4
reviewed
Dec 29, 2024
src/main/kotlin/net/ccbluex/liquidbounce/features/module/modules/misc/ModuleBookBot.kt
Outdated
Show resolved
Hide resolved
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/kotlin/net/ccbluex/liquidbounce/features/module/modules/misc/ModuleBookBot.kt
Fixed
Show fixed
Hide fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically fills in the books.