Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(installer): download correct piper arch #10

Closed
wants to merge 0 commits into from

Conversation

sammcj
Copy link

@sammcj sammcj commented Oct 9, 2024

Doesn't complete resolve #9 as it still seems to try and use Piper AMD64 for some reason, but could be unrelated.

@C-Loftus
Copy link
Owner

C-Loftus commented Oct 9, 2024

Thanks for adding this here! From what I can tell, upstream piper does not have proper MacOS builds.

rhasspy/piper#284
rhasspy/piper#480
rhasspy/piper#523

I was testing myself on MacOS previously and I also found iconv had a bit different behavior. (Or it could just be something different with how files are encoded). That is the program we use to remove special characters that piper would otherwise speak out literally and mess up the audiobook.

Unfortunately I think using the Docker container might be necessary for the time being. I do have some ideas that I will experiment with but it might be a little bit.

@C-Loftus C-Loftus marked this pull request as draft October 9, 2024 12:14
@C-Loftus
Copy link
Owner

Closing this for the time being since it doesn't appear to work and MacOS appears to be a bit of an issue with piper. If I do add it, I'll probably need to add some helper scripts to fix the binary before using it in piper.

@C-Loftus C-Loftus closed this Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

piper: exec format error on MacOS
2 participants