-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Implemented personal profile page for obaloluwa #25
base: main
Are you sure you want to change the base?
Conversation
@obah is attempting to deploy a commit to the BuidlGuidl Team on Vercel. A member of the Team first needs to authorize it. |
Well, that's not quite true 😅 Did you get stuck in "git hell" while updating your PR, @obah? I've been there plenty of times |
I didnt get stuck 😅 but a bunch of other commits were added after rebasing and pulling which could make the PR complicated again. So I just decided to close the branch and that previous PR then create a new one with just my profile page as the only commit. I could reopen the previous PR that I had rebased already if you prefer that. @derrekcoleman |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your personal page!
However, instead of closing your previous PR, you could have removed the "unnecessary" files from your previous PR and merged the commits from the other builders into it.
I've added some comments below for your reference.
packages/nextjs/app/builders/0x1C945Cd472EFBE3b34798AA49457Bc7415636E5D/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x1C945Cd472EFBE3b34798AA49457Bc7415636E5D/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x1C945Cd472EFBE3b34798AA49457Bc7415636E5D/page.tsx
Outdated
Show resolved
Hide resolved
Thank you for your review. I have attended to all the comments @phipsae |
Description
Additional Information
Your ENS/address: obaloluwa.eth