Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Implemented personal profile page for obaloluwa #25

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

obah
Copy link

@obah obah commented Jan 10, 2025

Description

  • Added profile page for Obaloluwa 0x1C945Cd472EFBE3b34798AA49457Bc7415636E5D

Additional Information

Your ENS/address: obaloluwa.eth

Screenshot_20250109_140551

Copy link

vercel bot commented Jan 10, 2025

@obah is attempting to deploy a commit to the BuidlGuidl Team on Vercel.

A member of the Team first needs to authorize it.

@derrekcoleman
Copy link
Member

This is not a duplicate of any existing pull request

Well, that's not quite true 😅 Did you get stuck in "git hell" while updating your PR, @obah? I've been there plenty of times

@obah
Copy link
Author

obah commented Jan 11, 2025

I didnt get stuck 😅 but a bunch of other commits were added after rebasing and pulling which could make the PR complicated again. So I just decided to close the branch and that previous PR then create a new one with just my profile page as the only commit.

I could reopen the previous PR that I had rebased already if you prefer that. @derrekcoleman

@phipsae phipsae self-requested a review January 11, 2025 08:36
Copy link

vercel bot commented Jan 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
batch12.buidlguidl.com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2025 8:43am

Copy link
Collaborator

@phipsae phipsae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your personal page!

However, instead of closing your previous PR, you could have removed the "unnecessary" files from your previous PR and merged the commits from the other builders into it.

I've added some comments below for your reference.

@obah
Copy link
Author

obah commented Jan 11, 2025

Thank you for your review. I have attended to all the comments @phipsae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants