Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nikolai leb issue 3 4 #16

Closed
wants to merge 3 commits into from

Conversation

NikolaiL
Copy link
Contributor

@NikolaiL NikolaiL commented Jan 8, 2025

Description

Proposed solution for Issues 3 & 4.

Additional Information

It's a proposed change if everyone agrees.

Used our batch number 12 to use it as a clock showing mid-day (or mid-night):

favicon

Also used it in the title and description:

Title: BuidlGuidl Batch 12
Description: Seizing the Right Time to Build

Screenshot 2025-01-08 at 10 55 43

Created a simple thumbnail, so here is how preview of the page looks like:

Screenshot 2025-01-08 at 10 55 38

Related Issues

_Closes #10 #9

Your ENS/address: 0x4b7b07D8BAf51975eeAb0E1eb4B481A5aC691ED6

Copy link

vercel bot commented Jan 8, 2025

@NikolaiL is attempting to deploy a commit to the BuidlGuidl Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
batch12.buidlguidl.com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 4:12am

@phipsae
Copy link
Collaborator

phipsae commented Jan 8, 2025

@NikolaiL Thanks so much for the PR and the nice logo, I like it! :)
Good PR descrition, too.

As a general guideline, it's a good practice to address one issue per PR to keep things clear and manageable. While I understand that the issues you worked on aren't overly complex and might seem related, they are intentionally separated to give newcomers the chance to solve easier issues.

Additionally, it’s always a good idea to check in on an issue beforehand to confirm that it's okay for you to take it on. This helps ensure everyone is aware and avoids potential overlaps.

May I kindly ask you to decide which issue you'd like to prioritize and create a new PR that focuses on that one?

@NikolaiL
Copy link
Contributor Author

NikolaiL commented Jan 8, 2025

@NikolaiL Thanks so much for the PR and the nice logo, I like it! :) Good PR descrition, too.

Thank yoU!

As a general guideline, it's a good practice to address one issue per PR to keep things clear and manageable. While I understand that the issues you worked on aren't overly complex and might seem related, they are intentionally separated to give newcomers the chance to solve easier issues.

Ok!

Additionally, it’s always a good idea to check in on an issue beforehand to confirm that it's okay for you to take it on. This helps ensure everyone is aware and avoids potential overlaps.

Ok!

May I kindly ask you to decide which issue you'd like to prioritize and create a new PR that focuses on that one?

Will do!

@NikolaiL NikolaiL closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants