Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CanvasOnChain: Show the canvas with all the pixel placements #29 #38

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

melanke
Copy link
Contributor

@melanke melanke commented Dec 14, 2024

Description

  • Changes on the PixelCanvas contract to fix the intialization script and iimplements a new method to retrieve all the pixels at once.
  • Presents the pixels retrieved from the contract.
  • Changes the scaffold config to use hardhat, otherwise the next:type-check would fail because the contract is not deployed yet.
  • Fixes the deploy script to keep the BatchRegistry deployment
  • ⚠️Disclaimer: This PR is based on Abidoyesimze's PR, which is still open, so you will see his changes too.

image

Additional Information

Related Issues

Closes #29

Your ENS/address:
0x2Bc096A12C5b37F035180aDeF70EB2B88351e5B8

Copy link

vercel bot commented Dec 14, 2024

@melanke is attempting to deploy a commit to the BuidlGuidl Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@phipsae phipsae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melanke, please exclude all files not related to this PR (all hardhat, etc.).
I understand you needed them for testing, but make sure to remove them before pushing to github.
As soon it is cleaned up, I will have a look at it.

Thanks!

@melanke
Copy link
Contributor Author

melanke commented Dec 15, 2024

@phipsae done, I've removed scaffold.config form the commit. But because of this I had to commit with --no-verify flag.

In the future it might be interesting to always rely on hardhat locally, instead of optimism, and use .env variables to control scaffold.config's targetNetworks on different environments.

@phipsae
Copy link
Collaborator

phipsae commented Dec 15, 2024

@phipsae done, I've removed scaffold.config form the commit. But because of this I had to commit with --no-verify flag.

In the future it might be interesting to always rely on hardhat locally, instead of optimism, and use .env variables to control scaffold.config's targetNetworks on different environments.

What I meant is, that in this PR there shouldn't be any files from the PR of @Abidoyesimze.

What to you mean? Can't you change easily the network inside scaffold.config .

@phipsae phipsae merged commit 38d30fc into BuidlGuidl:main Dec 20, 2024
3 checks passed
@phipsae
Copy link
Collaborator

phipsae commented Dec 20, 2024

Thanks! And merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CanvasOnChain: Show the canvas with all the pixel placements
2 participants