Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with Slack PDF previews #559

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Fix issues with Slack PDF previews #559

merged 5 commits into from
Nov 13, 2024

Conversation

ghinda
Copy link
Member

@ghinda ghinda commented Nov 13, 2024

Changes:

  • Fix issues with the Slack document (pdf, docx, etc.) previewer.
  • When the DOM was modified by the extension, Slack would crash the preview.
  • Prevent Briskine from running in the document previewer frame.

@ghinda
Fix issues with the slack pdf viewer.
30fc34e 
The pdf viewer stops working when the dom is modified by extensions.
Blocklist briskine for the pdf viewer.
@ghinda
Upgrade outdated.
3da2fc3
@ghinda
Tweak slack pdf-viewer url.
5770536
@ghinda
Upgrade firebase.
d12434f
@ghinda
Bump version.
3d8f8ee
@ghinda ghinda self-assigned this Nov 13, 2024
@ghinda ghinda merged commit b30bb4b into master Nov 13, 2024
1 check passed
@ghinda ghinda deleted the ghinda--slack-pdf branch November 13, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ghinda ghinda

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ghinda