REC Updates #647
Merged
REC Updates #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gtfierro
commented
Jul 31, 2024
•
gtfierro
commented
- adding REC repo as a submodule
- this should address missing definitions from Brick v1.4.0 is missing some REC classes #645
- adding in missing location classes to address Some deprecated Brick location classes are not replaced by REC classes in Brick v1.4.0 #644
- TODO:
- make Brick.ttl available for download on PRs (maybe not possible?)
- make sure the REC properties are defined (handled in another PR)
…hes.ttl` following existing styles and properties.
gtfierro
added a commit
that referenced
this pull request
Aug 22, 2024
* bump brick version * Move fume hood under exhaust fan class (#641) * Move fume hood under exhaust fan * Update fume hood definition * Deprecate Speed Status (#639) * Deprecate Speed Status * Update speed mode status definition and remove speed status definition * REC Updates (#647) * (no commit message provided) * Add deprecated brick locations from the 'x' file to `bricksrc/recpatches.ttl` following existing styles and properties. * remove bad module * adding rec * add submodules to checkout * small fixes * add pyproject * bump pyontoenv * Add property definitions for REC relationships (#650) * define REC relationships * only add the BSH property shape if it is a Brick property * fix relationship definition and catch these problems with an amended test * formatting on test * fix deactivation shape * small changes to tests * feat: add deprecations for brick:TeamRoom, brick:Lobby, and brick:Lounge in recpatches.ttl * chore: remove deprecated location classes from recpatches.ttl * feat: update deprecated brick classes to their corresponding rec classes in recpatches.ttl * Add artifact comment to PRs (#651) * feat: add deprecations for brick:TeamRoom, brick:Lobby, and brick:Lounge in recpatches.ttl * chore: remove deprecated location classes from recpatches.ttl * feat: update deprecated brick classes to their corresponding rec classes in recpatches.ttl * try to upload artifact on PR * fix if condition for v4 * only comment once * fixing the expressions. Use a variable to configure which version of python to use. cancel in-progress builds * patching more REC classes: Lounge, TEamRoom, Lobby, Hazardous Materials Storage, and Vertical Space * generate other brick distributions and add to the builds (#652) --------- Co-authored-by: Connor Cantrell <[email protected]>
gtfierro
added a commit
that referenced
this pull request
Aug 23, 2024
* bump brick version * Move fume hood under exhaust fan class (#641) * Move fume hood under exhaust fan * Update fume hood definition * Deprecate Speed Status (#639) * Deprecate Speed Status * Update speed mode status definition and remove speed status definition * REC Updates (#647) * (no commit message provided) * Add deprecated brick locations from the 'x' file to `bricksrc/recpatches.ttl` following existing styles and properties. * remove bad module * adding rec * add submodules to checkout * small fixes * add pyproject * bump pyontoenv * Add property definitions for REC relationships (#650) * define REC relationships * only add the BSH property shape if it is a Brick property * fix relationship definition and catch these problems with an amended test * formatting on test * fix deactivation shape * small changes to tests * feat: add deprecations for brick:TeamRoom, brick:Lobby, and brick:Lounge in recpatches.ttl * chore: remove deprecated location classes from recpatches.ttl * feat: update deprecated brick classes to their corresponding rec classes in recpatches.ttl * Add artifact comment to PRs (#651) * feat: add deprecations for brick:TeamRoom, brick:Lobby, and brick:Lounge in recpatches.ttl * chore: remove deprecated location classes from recpatches.ttl * feat: update deprecated brick classes to their corresponding rec classes in recpatches.ttl * try to upload artifact on PR * fix if condition for v4 * only comment once * fixing the expressions. Use a variable to configure which version of python to use. cancel in-progress builds * patching more REC classes: Lounge, TEamRoom, Lobby, Hazardous Materials Storage, and Vertical Space * fixing up rec patches * fixing up script to generate release notes --------- Co-authored-by: Connor Cantrell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.