Swapping out brick quantitykinds for QUDT QKs when Brick adds nothing #570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, Brick augments QUDT's quantity kinds (e.g. by adding new units, refining the existing units, or altering the definition to be more specific to the building/HVAC context).
Temperature is a good example of this. `Temperature` in Brick is `ThermodynamicTemperature` in QUDT, but Brick also adds some special subtypes
In others, Brick simply copies all of the properties from the existing QUDT quantity kind. This PR removes redundant QKs from Brick and expands the
hasQuantity
relationship to accept QUDT QKs in addition to Brick's own.Addresses an initial thought in #450