Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Base Tank class and deprecate Water_Tank #553

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

connorjcantrell
Copy link
Contributor

@connorjcantrell connorjcantrell commented Sep 1, 2023

This PR introduces a new foundational class, Tank, under the 'Equipment' class. This class will serve as the parent class for specialized tanks utilized in HVAC, plumbing, and irrigation systems.

Prior to introducing substance-specific subclasses like Water, we are establishing two key base classes: Storage_Tank, Thermal_Expansion_Tank, and Separation_Tank. The Storage Tank class will serve as the parent for all tanks designed primarily for storing various substances. The Thermal Expansion Tank class is for tanks that are engineered to accommodate volume changes due to temperature/ pressure fluctuations. The Separation_Tank class tank used in conjunction with a filter to facilitate the separation of filtrate material for disposal. (I am open for suggestions on renaming Separation Tank, but it seemed necessary parent class for something like a Grease Interceptor.)

By first laying down these general categories, we can define substance-specific subclasses, such as Chilled Water Storage Tank or Hot Water Thermal Expansion Tank.

In alignment with these changes, this PR also deprecates the existing Water_Tank class and removes its prior categorization under the 'Space' class. Tanks serve specific functional roles in building systems, be it storage, thermal expansion, or other specialized purposes. Their functional attributes align more closely with equipment rather than spatial entities.

@JoelBender
Copy link
Contributor

Here at Cornell we have a Chilled_Water_Thermal_Storage_Tank, so please include "thermal".

(and as an aside, the acoustics inside this before they filled it up were amazing)

@connorjcantrell
Copy link
Contributor Author

connorjcantrell commented Sep 5, 2023

@JoelBender thanks for the providing a link to Thermal Storage Tank. I agree that aThermal_Energy_Storage_Tank, followed by the subclasses of Chilled_Water_Thermal_Energy_Storage_Tank and Hot_Water_Thermal_Energy_Storage_Tank should be added to the class

@JoelBender
Copy link
Contributor

JoelBender commented Sep 5, 2023

(update: somehow I thought you were asking me a question, but after re-reading this you didn't!)

The tank is "charged" by pumping chilled water into the bottom of the tank and draining off an identical amount of warm water off the top. When the tank is "discharged" the warm chilled water from the campus is pumped into the top of the tank and the chilled water drained off the bottom. The tank is charged at night from chillers when electricity is the least expensive, and used as peak load shaving during the day to supplement the chillers, perhaps by not having to run multiple chillers to keep up with the load.

There is a thermocline that drifts up and down and the layers of hot and cold water do not mix (much, there is a little).

Chilled water storage is very similar to ice storage, with the exception that the medium doesn't go through a phase transition. Ice storage "tanks" are smaller and typically serve a single building.

bricksrc/deprecations.py Outdated Show resolved Hide resolved
@gtfierro gtfierro merged commit 661fba6 into BrickSchema:master Sep 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants