Introduce Base Tank
class and deprecate Water_Tank
#553
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new foundational class,
Tank
, under the 'Equipment' class. This class will serve as the parent class for specialized tanks utilized in HVAC, plumbing, and irrigation systems.Prior to introducing substance-specific subclasses like Water, we are establishing two key base classes:
Storage_Tank
,Thermal_Expansion_Tank
, andSeparation_Tank
. The Storage Tank class will serve as the parent for all tanks designed primarily for storing various substances. The Thermal Expansion Tank class is for tanks that are engineered to accommodate volume changes due to temperature/ pressure fluctuations. TheSeparation_Tank
class tank used in conjunction with a filter to facilitate the separation of filtrate material for disposal. (I am open for suggestions on renaming Separation Tank, but it seemed necessary parent class for something like a Grease Interceptor.)By first laying down these general categories, we can define substance-specific subclasses, such as Chilled Water Storage Tank or Hot Water Thermal Expansion Tank.
In alignment with these changes, this PR also deprecates the existing
Water_Tank
class and removes its prior categorization under the 'Space' class. Tanks serve specific functional roles in building systems, be it storage, thermal expansion, or other specialized purposes. Their functional attributes align more closely with equipment rather than spatial entities.