-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed PHP 5 dependencies and added php7.0-mbstring dependancy #40
base: master
Are you sure you want to change the base?
Conversation
Removed the php5 dependencies that was suggested in BrewPi#39. The script now runs fine, however, the website is still unavailable after it completes.
There was a missing dependency, `php7.0-mbstring` that was causing the `/index.php` to not display, and throwing an error in the `/var/log/apache2/error.log`: ``` PHP Fatal error: Uncaught Error: Call to undefined function mb_convert_encoding() in /var/www/html/index.php:53\nStack trace:\n#0 /var/www/html/index.php(24): prepareJSON('{"beerName": "S...')\n#1 {main}\n thrown in /var/www/html/index.php on line 53 ```
Thanks for the PR :) Regarding configobj, it's already installed a few lines down using pip, why is the apt install needed? |
here is the output from running the brewpi.py
this is a fresh install, so when I run the python script, it appears to be missing both python-configobj and psutil from pip. |
Has this been merged yet? I'm still getting exactly the same error as in #39 |
Removed the php 5.0 dependencies from the install.sh script. I also added the
php7.0-mbstring
dependency that was being called by theindex.php
. The missing dependency would cause a500
error and throw and error in the/var/log/apache2/error.log
This can all be found in issue #39.