Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): ✨ boolean values handled as test data in excel s… #912

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

mfaisalkhatri
Copy link
Contributor

@mfaisalkhatri mfaisalkhatri commented Oct 11, 2024

…heet

Boolean values were not handled correctly as test data. This has been fixed in this ticket

Closes: #908

Type of changes?

  • Bug fixes: Non-breaking change which fixes an issue
  • New feature: Non-breaking change which adds a new feature
  • Performance improvement: Non-breaking change which improves performance
  • Documentation: Non-breaking change which improves documentation
  • Other: Non-breaking change which does not fit into the above categories
  • Breaking change: A breaking change which requires a new version of the library

Checklist for Java project

  • Change not related to Java project

Following checklists are optional if above checkbox is selected:

  • Copyright banner comment added to newly added files, except *.md, *.yml, *.json?
  • Proper JavaDoc updated in main and test classes for all public classes and methods?
  • Tests added for changes?
  • Tests are passing locally?
  • Check style checks are passing locally?
  • Test coverage is at least 80% for newly added changes?
  • There are no SonarCloud issues?
  • README updated? (if applicable)
  • Documentation website updated for the PR raised?

Checklist for Website

  • Change not related to Website project

Following is optional if above checkbox is selected:

  • Lint check passes locally?
  • Prettier check passes locally?
  • Build command working fine locally?

Reviewers

@BoykaFramework/boyka-core

Important

Make sure to check the Allow edits from maintainers box below this window

Boolean values were not handled correctly as test data. This has been fixed in this ticket
@github-actions github-actions bot added the 🚀 pr: new feature PR which introduces new features label Oct 11, 2024
@mfaisalkhatri mfaisalkhatri marked this pull request as ready for review October 11, 2024 17:56
@mfaisalkhatri mfaisalkhatri requested a review from a team as a code owner October 11, 2024 17:56
Copy link
Member

@WasiqB WasiqB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look into the review comments.

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

sonarcloud bot commented Oct 11, 2024

@WasiqB WasiqB merged commit 74aa390 into main Oct 11, 2024
21 checks passed
@WasiqB WasiqB deleted the issue-908 branch October 11, 2024 20:54
@WasiqB
Copy link
Member

WasiqB commented Oct 17, 2024

🚀 This pull request is included in v2.2.0. See Release 2.2.0 for release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 pr: new feature PR which introduces new features
Projects
Development

Successfully merging this pull request may close these issues.

✨ Update feature: Boolean values should be supported in the Excel Sheet data provider.
3 participants