Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): 🐛 fixing issues in the documentations #902

Merged
merged 5 commits into from
Oct 3, 2024
Merged

Conversation

WasiqB
Copy link
Member

@WasiqB WasiqB commented Oct 2, 2024

Closes: #894

Type of changes?

  • Bug fixes: Non-breaking change which fixes an issue
  • New feature: Non-breaking change which adds a new feature
  • Performance improvement: Non-breaking change which improves performance
  • Documentation: Non-breaking change which improves documentation
  • Other: Non-breaking change which does not fit into the above categories
  • Breaking change: A breaking change which requires a new version of the library

Checklist for Java project

  • Change not related to Java project

Following checklists are optional if above checkbox is selected:

  • Copyright banner comment added to newly added files, except *.md, *.yml, *.json?
  • Proper JavaDoc updated in main and test classes for all public classes and methods?
  • Tests added for changes?
  • Tests are passing locally?
  • Check style checks are passing locally?
  • Test coverage is at least 80% for newly added changes?
  • There are no SonarCloud issues?
  • README updated? (if applicable)
  • Documentation website updated for the PR raised?

Checklist for Website

  • Change not related to Website project

Following is optional if above checkbox is selected:

  • Lint check passes locally?
  • Prettier check passes locally?
  • Build command working fine locally?

Reviewers

@BoykaFramework/boyka-core

Important

Make sure to check the Allow edits from maintainers box below this window

@WasiqB WasiqB self-assigned this Oct 2, 2024
@github-actions github-actions bot added the 🐛 pr: bug fix PR which fixes a bug label Oct 2, 2024
@WasiqB WasiqB marked this pull request as ready for review October 2, 2024 19:01
@WasiqB WasiqB requested a review from a team as a code owner October 2, 2024 19:01
Copy link
Contributor

@mfaisalkhatri mfaisalkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the documentation as per the review comments.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
website/docs/framework-docs/getting-started/quickstart.md Outdated Show resolved Hide resolved
website/docs/framework-docs/getting-started/quickstart.md Outdated Show resolved Hide resolved
website/docs/framework-docs/getting-started/quickstart.md Outdated Show resolved Hide resolved
website/docs/framework-docs/getting-started/quickstart.md Outdated Show resolved Hide resolved
website/docs/framework-docs/intro.mdx Outdated Show resolved Hide resolved
@WasiqB WasiqB merged commit 262f2b4 into main Oct 3, 2024
9 checks passed
@WasiqB WasiqB deleted the issue-894 branch October 3, 2024 07:00
@WasiqB
Copy link
Member Author

WasiqB commented Oct 3, 2024

🚀 This pull request is included in v2.1.1. See Release 2.1.1 for release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 pr: bug fix PR which fixes a bug
Projects
Development

Successfully merging this pull request may close these issues.

🐛 New Bug: Documentation Issues
2 participants