Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simpifly Dockerfiles #5293

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

johnroyer
Copy link
Contributor

some updates:

  • Remove deprecated syntax
  • use mlocati/docker-php-extension-installer to install PHP extensions: easier to read and install dependencies automatically
  • use multiple docker images: docker image layers are re-usable, it can accelerate build speed while working on Dockerfile

Notes: everything should be works on docker compose up

@ssddanbrown
Copy link
Member

Thanks for offering this @johnroyer but I personally prefer the original means of installing extensions and composer to be honest, rather than getting another container and external script involved.

@johnroyer
Copy link
Contributor Author

How do you think if I revert the commit of php extension installer ?

@ssddanbrown
Copy link
Member

Assuming that reverts both composer and extension install changes, then yeah should be good.
Just an FYI, I'll probably squash merge this rather than having (potentially) 7 commits for altering a single file.

@johnroyer
Copy link
Contributor Author

Assuming that reverts both composer and extension install changes

OK, i will revert both

I will rebase onto develop before push.

@johnroyer
Copy link
Contributor Author

I merge changes to 2 commits. Seems everything is fine on build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants