Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to build dependencies only #221

Closed
wants to merge 2 commits into from

Conversation

kkendzia
Copy link
Contributor

I have a use case where it's only necessary to build dependencies without the package itself. I tried to added the option, but I am not very pleased with the _checkDepsOnly function. Maybe you have an idea.

@codecov-io
Copy link

codecov-io commented Nov 20, 2018

Codecov Report

Merging #221 into master will increase coverage by 0.15%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
+ Coverage   74.07%   74.23%   +0.15%     
==========================================
  Files          26       26              
  Lines        9297     9315      +18     
==========================================
+ Hits         6887     6915      +28     
+ Misses       2410     2400      -10
Impacted Files Coverage Δ
pym/bob/input.py 87.6% <ø> (+0.1%) ⬆️
pym/bob/cmds/build.py 85.66% <96.29%> (+0.21%) ⬆️
pym/bob/audit.py 63.86% <0%> (+2.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0f181d...7a531a5. Read the comment docs.

@jkloetzke
Copy link
Member

I'm wondering if this shouldn't be realized with the query language. In principle bob build '<path-to-package>/*' should already be almost what you want. The only thing that might not be built are some tools that are used by the package but are not used by any of it's dependencies. This reminds me of #187 which is basically the same problem.

Maybe something like bob build '<path-to-package>/deps@*'. What do you think?

@kkendzia
Copy link
Contributor Author

Would be fine for me! Yeah I also tried /* and encountered the same issue with tools.

@kkendzia
Copy link
Contributor Author

kkendzia commented Nov 26, 2018

Mh do you think /child@* should work too?

Edit: Forget it, just tried it

@jkloetzke
Copy link
Member

I did have a look and solving the problem with the query language is not so easy as it seems. Nonetheless I think this is the correct approach given that #187 needs internally the same information. I would rather not solve this only for the local build with this PR.

Still, many thanks for submitting the PR in the first place.

@jkloetzke jkloetzke closed this Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants