-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Battle engine revamp (turn sequence) #337
Draft
Aeliko
wants to merge
11
commits into
BluRosie:move-dev
Choose a base branch
from
Aeliko:battle-engine-revamp
base: move-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aeliko
added
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
help wanted
Extra attention is needed
rom code
Has to do with C code injected into ROM
build system
Issue with Build System code
moves
Issue with a move's operation or interaction
abilities
Issue with an ability's operation or interaction
items
Issue with an item's operation or interaction
modernization
Current/Later gen Functionality
text
Issue related to text
labels
Oct 20, 2024
This was
linked to
issues
Oct 22, 2024
Open
Open
do you need anything from me to get this working? |
Not yet, just need a code review when I finish soon™️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
abilities
Issue with an ability's operation or interaction
bug
Something isn't working
build system
Issue with Build System code
documentation
Improvements or additions to documentation
enhancement
New feature or request
help wanted
Extra attention is needed
items
Issue with an item's operation or interaction
modernization
Current/Later gen Functionality
moves
Issue with a move's operation or interaction
rom code
Has to do with C code injected into ROM
text
Issue related to text
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Remind me to either draw a diagram here or create a wiki page explaining what and why we need this.
Address #313 , #314 , #317 , #340