Basic monitor solution #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solr/core/src/java/org/apache/solr/update/processor/MonitorUpdateProcessor.java
Outdated
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/update/processor/MonitorUpdateProcessorFactory.java
Outdated
Show resolved
Hide resolved
solr/core/src/test/org/apache/solr/cloud/QueryRegisterTest.java
Outdated
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/handler/QueryRegisterHandler.java
Outdated
Show resolved
Hide resolved
| */ | ||
| synchronized private void registerQueryToZk(SolrZkClient client, String queryId, Query query, String paramString) throws KeeperException, InterruptedException, JoseException { | ||
| String path = MonitorUpdateProcessorFactory.zkQueryPath; | ||
| if (!client.exists(path, true)) { |
There was a problem hiding this comment.
Doing this on initializaton of the handler/update request processor factory will probably suffice and lower the number of zk calls you need to make.
There was a problem hiding this comment.
Moving these code to handler.init() caused some exceptions and it failed to create cores. So I added a flag variable here to avoid unnecessary zk calls.
solr/core/src/java/org/apache/solr/handler/QueryRegisterHandler.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented basic functionalities.
Fixed major issues.