AWS Route53 Alias Record Support #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicBreuker
requested review from
bishopfaure and
dbravo-bishopfox
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Card
Adds support for Alias records in the
cloudfox aws route53command. These records are currently not shown, and you could miss interesting things because of that.Details
AWS Route53 supports special DNS records called Alias (docs). They are configured like CNAMEs and allow you to point records like
mybucket.company.comto AWS resources like an S3 bucket. When resolved, they behave like A/AAAA records.The SDK reports these records in a special field. Therefore cloudfox currently does not output them. The PR checks adds them as a special case. They get printed out with type
Alias[A]orAlias[AAAA]and the value will be some identifier of the AWS resource the record points to.