Change grep to use '-' rather than '_' in factorio server file name #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadcx
suggested changes
Nov 15, 2024
| @@ -483,7 +483,7 @@ function install(){ | |||
| fi | |||
|
|
|||
| # parse the response | |||
| if filename=$(echo "${httpresponse}" |grep -oP '(?<=^location: )[^\?]+' |grep -oP 'factorio_headless.+'); then | |||
| if filename=$(echo "${httpresponse}" |grep -oP '(?<=^location: )[^\?]+' |grep -oP 'factorio-headless.+'); then | |||
There was a problem hiding this comment.
- is a special character in PCRE (Perl regex): 'factorio-headless.+'
The following will allow both to co-exist: 'factorio[_-]headless.+'
UPD: huh, - works fine on its own nonetheless 😮
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the Factorio download uses a hyphen now in the server download - found the issue when first running the install with factorio-init