Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing dependency on focal #1271

Closed
wants to merge 2 commits into from
Closed

Fixed missing dependency on focal #1271

wants to merge 2 commits into from

Conversation

Shivanshu10
Copy link

Hey,
I tried fixing #1269 please review my commits
Thanks

added release focal to fix missing deps
new cmd line arg added asking for libffi version
@ivg
Copy link
Member

ivg commented Feb 23, 2021

Dear @Shivanshu10, please accept my apologies for not reviewing your PR, I missed it in the notifications. Totally my fault. Please reopen it if you would like to have it finished (as well as your previous #1270). I still believe that we can make it happen without breaking backward compatibility. If it won't work, then we might consider having an alternative mechanism for focal releases. Essentially, our main problem here is where to upload the built binaries, not the build process itself. We are picking the release artifacts upload are as the most convenient location (well at least from our users perspective), but it is hard to access it from the actions. There are other locations, maybe less obvious (which we could circumvent by properly documenting them), such as docker hub or build artifacts of the github actions itself. The latter is probably the cheapest solution.

Anyway, feel free to reopen this if you're interested in finishing this work. Also, don't hesitate to use our Gitter channel and ping me if I am not replying. My git notification panel is overwhelmed with noise. Again, apologies for not replying to this before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants