Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force field fling on teleport #2122

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Force field fling on teleport #2122

wants to merge 6 commits into from

Conversation

tastybento
Copy link
Member

@tastybento tastybento commented Apr 26, 2023

Flings hostile mobs away from the player when they teleport rather than removing them. Config options are in BentoBox's config.yml. Closes #1643

Please try this @BONNe and see what you think. I think a power of 5 works pretty well.

@tastybento tastybento requested a review from BONNe April 26, 2023 02:05
@tastybento tastybento self-assigned this Apr 26, 2023
@tastybento
Copy link
Member Author

I'll fix the tests tonight.

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

83.9% 83.9% Coverage
0.0% 0.0% Duplication

@BONNe
Copy link
Member

BONNe commented Apr 29, 2023

While testing this i notice that even putting very small power, it still throws entities far.

Also, i notice that you can create creeper cannons with Power 5 by throwing entities to other player islands if distance between islands is 50

@tastybento
Copy link
Member Author

Hmm. Good point. How far do you think mobs need to be pushed back? 5 blocks? Or maybe 10?

@BONNe
Copy link
Member

BONNe commented Apr 30, 2023

I think 10 to 15, as 5 is still a distance creeper can sneak up and explode.

@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

83.9% 83.9% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On teleport: Push entities away instead of removing them
2 participants