-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components should not be blueprint types. #139
Draft
iago-lito
wants to merge
91
commits into
dev
Choose a base branch
from
blueprints
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 15, 2024
iago-lito
force-pushed
the
dev
branch
7 times, most recently
from
March 25, 2024 16:01
1684652
to
5d1c9e5
Compare
iago-lito
force-pushed
the
blueprints
branch
12 times, most recently
from
July 30, 2024 15:17
5a159d5
to
31c7d43
Compare
.. alongside 'ref' and 'index' to improve error messages further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address this design mistake: blueprints and components should be two separate types hierarchies.
Using singleton component instances as ergonomical handles should improve #131.
Take this opportunity to better unify
brought
blueprint, eitherimplied
,embedded
orunbrought
depending on blueprint value.This will surface as breaking API changes, but I expect them to remain minor. One major positive change I expect is the simplification of all code within
src/components/
: this should not become so complex than no one can hack in.