Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imagick hotfixes #38

Merged
merged 1 commit into from
Jun 17, 2024
Merged

imagick hotfixes #38

merged 1 commit into from
Jun 17, 2024

Conversation

N6REJ
Copy link
Collaborator

@N6REJ N6REJ commented Jun 16, 2024

PR Type

Enhancement


Description

  • Updated ImageMagick URLs to a newer version in deps.properties for PHP 8.1.28, 8.2.19, and 8.3.7.
  • Updated Imagick URLs to a newer version in exts.properties for PHP 8.1.28, 8.2.19, and 8.3.7.
  • Updated PEAR URLs to a newer version in pear.properties for PHP 8.1.28, 8.2.19, and 8.3.7.
  • Updated bundle release date in build.properties.

Changes walkthrough 📝

Relevant files
Enhancement
10 files
deps.properties
Update ImageMagick URL in deps.properties                               

bin/php8.1.28/deps.properties

  • Updated ImageMagick URL to a newer version.
+1/-1     
exts.properties
Update Imagick URL in exts.properties                                       

bin/php8.1.28/exts.properties

  • Updated Imagick URL to a newer version.
+1/-1     
pear.properties
Update PEAR URL in pear.properties                                             

bin/php8.1.28/pear.properties

  • Updated PEAR URL to a newer version.
+1/-1     
deps.properties
Update ImageMagick URL in deps.properties                               

bin/php8.2.19/deps.properties

  • Updated ImageMagick URL to a newer version.
+1/-1     
exts.properties
Update Imagick URL in exts.properties                                       

bin/php8.2.19/exts.properties

  • Updated Imagick URL to a newer version.
+1/-1     
pear.properties
Update PEAR URL in pear.properties                                             

bin/php8.2.19/pear.properties

  • Updated PEAR URL to a newer version.
+1/-1     
deps.properties
Update ImageMagick URL in deps.properties                               

bin/php8.3.7/deps.properties

  • Updated ImageMagick URL to a newer version.
+1/-1     
exts.properties
Update Imagick URL in exts.properties                                       

bin/php8.3.7/exts.properties

  • Updated Imagick URL to a newer version.
+1/-1     
pear.properties
Update PEAR URL in pear.properties                                             

bin/php8.3.7/pear.properties

  • Updated PEAR URL to a newer version.
+1/-1     
build.properties
Update bundle release date in build.properties                     

build.properties

  • Updated bundle release date.
+1/-1     

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

@N6REJ N6REJ added the bug 🐛 For known bugs label Jun 16, 2024
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5] 2
🧪 Relevant tests No
🔒 Security concerns No
⚡ Key issues to review Duplicate URLs:
The PR contains duplicate URLs in the properties files after the update lines. This might be an error in the diff display or an actual issue in the file. It's important to ensure that each property file only contains the correct, updated URL without duplication.

Copy link

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Possible issue
Verify the correctness of the bundle.release date to ensure it is not a typo

Verify that the bundle.release date is correct and intended. The new date 2024.6.16 is
significantly different from the previous 2024.5.26, which might be a typo.

build.properties [3]

-bundle.release = 2024.6.16
+bundle.release = 2024.5.26
 
  • Apply this suggestion
Suggestion importance[1-10]: 3

Why: The suggestion is valid in questioning the significant date change, but it's not a critical issue and could be intentional. Verification is good practice, but not a major concern.

3

@jwaisner jwaisner merged commit e5c95d0 into main Jun 17, 2024
2 checks passed
@jwaisner jwaisner deleted the imagick-fix branch June 17, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 For known bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants