Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove pre-push hook #556

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DecampsRenan
Copy link
Contributor

@DecampsRenan DecampsRenan commented Jan 17, 2025

Describe your changes

closes #176

I removed the pre-push git hook (because code will be formatted by lint-staged on each commit, and its a lot faster)

I also upgraded husky to the latest version, it should be a little bit faster now

Documentation

Checklist

  • I performed a self review of my code
  • I ensured that everything is written in English
  • I tested the feature or fix on my local environment
  • I ran the pnpm storybook command and everything is working
  • If applicable, I updated the translations for english and french files
    (If you cannot update the french language, just let us know in the PR description)
  • If applicable, I updated the README.md
  • If applicable, I created a PR or an issue on the documentation repository
  • If applicable, I’m sure that my feature or my component is mobile first and available correctly on desktop

Summary by CodeRabbit

  • Chores
    • Updated Husky (Git hooks library) from version 9.0.11 to 9.1.7
    • Simplified pre-commit hook configuration
    • Removed pre-push hook script

Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
start-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 8:37am

Copy link
Contributor

coderabbitai bot commented Jan 17, 2025

Walkthrough

The pull request involves modifications to the Husky Git hooks configuration. The .husky/pre-commit file has been simplified, removing the shebang and Husky script sourcing. The .husky/pre-push file has been completely removed. Additionally, the Husky dependency in package.json has been upgraded from version 9.0.11 to 9.1.7.

Changes

File Change Summary
.husky/pre-commit Simplified hook script, removed shebang and Husky script sourcing
.husky/pre-push Completely removed pre-push hook script
package.json Upgraded Husky dependency from 9.0.11 to 9.1.7

Assessment against linked issues

Objective Addressed Explanation
Use lint-staged instead of lint on pre-push hook [#176]
Remove pre-push git hook if no blockers exist [#176]

The changes directly address the objectives outlined in issue #176 by removing the pre-push hook and simplifying the pre-commit hook configuration. The modifications align with the suggestion to use lint-staged and remove unnecessary linting steps during the Git push process.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9556ef7 and 0e30931.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • .husky/pre-commit (1 hunks)
  • .husky/pre-push (0 hunks)
  • package.json (1 hunks)
💤 Files with no reviewable changes (1)
  • .husky/pre-push
✅ Files skipped from review due to trivial changes (2)
  • package.json
  • .husky/pre-commit
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Playwright E2E Tests

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@DecampsRenan DecampsRenan marked this pull request as ready for review January 17, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use lint-staged instead of lint on pre-push git hook
1 participant