-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove pre-push hook #556
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe pull request involves modifications to the Husky Git hooks configuration. The Changes
Assessment against linked issues
The changes directly address the objectives outlined in issue #176 by removing the pre-push hook and simplifying the pre-commit hook configuration. The modifications align with the suggestion to use 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Quality Gate passedIssues Measures |
Describe your changes
closes #176
I removed the pre-push git hook (because code will be formatted by lint-staged on each commit, and its a lot faster)
I also upgraded husky to the latest version, it should be a little bit faster now
Documentation
Checklist
pnpm storybook
command and everything is workingIf applicable, I updated the translations for english and french files(If you cannot update the french language, just let us know in the PR description)
If applicable, I updated the README.mdIf applicable, I created a PR or an issue on the documentation repositoryIf applicable, I’m sure that my feature or my component is mobile first and available correctly on desktopSummary by CodeRabbit