Add transaction feedback to card #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also disables previous app-wide UI
Adds a badge for each type or errors Adds a messages for each type of event Tested for most events
Also implements the new LoadingOverlay api across all pages
|
@activate-glacier-instinct is attempting to deploy a commit to the bankless-dao-loans Team on Vercel. A member of the Team first needs to authorize it. |
activate-glacier-instinct
changed the title
geositta
approved these changes
May 29, 2022
There was a problem hiding this comment.
@activate-glacier-instinct This looks superb - one thing I noticed is that upon successfully editing a trove that the modal shifts very suddenly to the non editing state so you don't really have a chance to see that your change to the trove was successful. Would you please add an issue for that as a future enhancement? I am not sure what would be required which is why I would appreciate any ideas around scoping you might have, thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #209
Add new functionality for showing transaction feedback on the card
Screenshots
Confirmed
Waiting For Confirmation
Waiting For Approval
Failed
Cancelled