Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS AR Metal Validation Error #1403

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

iOS AR Metal Validation Error #1403

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d178766
iOS AR Metal Validation Error
CedricGuillemet Jul 17, 2024
51115eb
spaces
CedricGuillemet Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Dependencies/xr/Source/ARKit/XR.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -946,6 +946,8 @@ void UpdateXRView(MTKView* activeXRView) {

// Finalize rendering here & push the command buffer to the GPU.
[currentCommandBuffer commit];

[currentCommandBuffer waitUntilCompleted];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What validation error does this fix? I don't think this is good for perf. I think we used to do this and tried to get rid of it, because it blocks this thread until the command buffer has been executed by the gpu.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know but I'd like to narrow down the issue to see if it's this command buffer that's causing all the crashes.


return std::make_unique<Frame>(*this);
}
Expand Down