Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic code for fcsv reader #2

Open
wants to merge 1 commit into
base: landmark_app_20190405
Choose a base branch
from
Open

add basic code for fcsv reader #2

wants to merge 1 commit into from

Conversation

ArjitJ
Copy link
Collaborator

@ArjitJ ArjitJ commented May 14, 2019

Status

READY/WORK IN PROGRESS/HOLD

Description

A few sentences describing the overall goals of the pull request's commits.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Todos

  • Tests
  • Documentation

Impacted Areas in Application

List general components of the application that this PR will affect:
*

Copy link
Member

@hjmjohnson hjmjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For our files, please conform to the "black" tool specification for style formatting.

pip install black
black *.py

@hjmjohnson
Copy link
Member

@ArjitJ Please squash these commits. There is no need to keep both patches as one is simply a fix of the other.

reformatted using black

change fcsvreader data format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants