Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getters to wallet info L1 data #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

crisdut
Copy link
Member

@crisdut crisdut commented Nov 21, 2024

Description

This PR adds two new methods to access wallet info from layer 1, similar to those we have in layer 2. This simplifies the implementation of some modules, such as custom indexers and the asynchronous persistence layer.

In my case, where I was using IndexedDB (browser), adding these methods reduced my code by ~30% and made it more stable, as WASM's main problems are only detectable at runtime.

@crisdut crisdut requested a review from dr-orlovsky November 21, 2024 11:59
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 4.9%. Comparing base (139d936) to head (e3f00a2).

Files with missing lines Patch % Lines
src/wallet.rs 0.0% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #75     +/-   ##
=======================================
- Coverage     4.9%   4.9%   -0.0%     
=======================================
  Files          24     24             
  Lines        2315   2317      +2     
=======================================
  Hits          113    113             
- Misses       2202   2204      +2     
Flag Coverage Δ
rust 4.9% <0.0%> (-<0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant