Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test round trip #74

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

patrix252
Copy link
Contributor

This PR adds some simple tests to check that string round-trip conversion of all objects implementing from_str works fine.

In addition, I've also formatted the code with cargo +nightly fmt --all.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.9%. Comparing base (784ff20) to head (8ed740f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #74     +/-   ##
=======================================
+ Coverage     0.0%   4.9%   +4.9%     
=======================================
  Files          24     24             
  Lines        2259   2315     +56     
=======================================
+ Hits            0    113    +113     
+ Misses       2259   2202     -57     
Flag Coverage Δ
rust 4.9% <100.0%> (+4.9%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-orlovsky
Copy link
Member

Thank you very much and congrats with the first time contribution!

Re cargo fmt, this is a new nightly version which once again changed rules with no notice. I will fix it by using edition_style new option in cargofmt.toml and will ask you to rebase after.

@dr-orlovsky
Copy link
Member

I have merged fmt changes and now you can just skip formatting commit. After that I will be able to merge this PR. Thank you!

@patrix252 patrix252 force-pushed the patrix/test-round-trip branch from 36d682c to 8ed740f Compare November 4, 2024 09:09
Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 8ed740f

Congrats with the first contribution!

@dr-orlovsky dr-orlovsky merged commit 139d936 into BP-WG:master Nov 4, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants