Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker wrapper: always mount slot dir at WORKDIR #5886

Merged
merged 6 commits into from
Nov 7, 2024
Merged

Commits on Nov 6, 2024

  1. docker_wrapper: always mount slot dir at WORKDIR

    This means that the tree rooted at WORKDIR is on the host filesystem,
    and therefore survives system restarts;
    otherwise it wouldn't.
    
    This also simplifies file access from containers.
    There's no need to copy input files from the slot dir to the container;
    they're already in the container.
    Similar with output files.
    Remove these capabilities from the wrapper.
    
    If a Docker app wants to access files in the project dir
    (e.g. if they're huge files, shared with other jobs)
    it can do so by mounting the project dir (using job.toml)
    and then parsing the link files.
    
    Merge the two test cases (copy and mount) into one
    in both standalone and app_test.
    davidpanderson committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0240292 View commit details
    Browse the repository at this point in the history
  2. tweaks

    davidpanderson committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    bb6ea61 View commit details
    Browse the repository at this point in the history
  3. tweak

    davidpanderson committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    6cd9e0f View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. debug

    davidpanderson committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    2cd0c73 View commit details
    Browse the repository at this point in the history
  2. docker_wrapper: use relative path when mounting the project dir

    Docker chokes on the Windows-style "c:\blah..." path
    davidpanderson committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    13a7060 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d06999a View commit details
    Browse the repository at this point in the history