-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: remove unused Docker images and containers on startup #5877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The images and containers created by docker_wrapper have a particular form: boinc__<proj>__<wuname> and boinc__<proj>__<resultname>. docker_wrapper normally cleans up after itself. But if it crashes these objects could hang around forever, taking up disk space. So we clean them up on client startup, as follows: make lists of the names for active Docker tasks. Then go through the list of Docker images and containers. Remove any that - were created by Docker wrapper (i.e. have boinc__ names) - aren't in the active-task lists On Unix, do this on the host itself if it has Docker installed. On Win, do it for every WSL distro that has Docker installed.
Make 'verbose' an attribute of DOCKER_CONN.
@davidpanderson, please fix build errors |
AenBleidd
approved these changes
Nov 2, 2024
@davidpanderson,
|
AenBleidd
approved these changes
Nov 2, 2024
@davidpanderson, linux is still failing because of FCGI for the server build |
Maybe we should divide util.cpp into - things used from the scheduler and file upload handlers (where we need boinc::stdio stuff) - everything else
AenBleidd
approved these changes
Nov 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5877 +/- ##
============================================
- Coverage 10.75% 10.73% -0.02%
Complexity 1068 1068
============================================
Files 280 280
Lines 36555 36598 +43
Branches 8472 8482 +10
============================================
Hits 3930 3930
- Misses 32236 32279 +43
Partials 389 389
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The names of images and containers created by docker_wrapper have a particular form:
boinc__ and boinc__.
docker_wrapper normally cleans up after itself.
But if it crashes, these objects could hang around forever, taking up disk space.
So clean them up on client startup, as follows:
make lists of the image/container names for active Docker tasks.
Then go through the Docker images and containers.
Remove any that
On Unix, do this on the host itself if it has Docker installed.
On Win, do it for every WSL distro that has Docker installed.