Add docker_wrapper and associated client/server changes #5855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitalii Koshura <[email protected]>
Instead, use a WSL container containing the docker engine, and send it commands using the WSL mechanism
An image (especially in the universal model) may contain WU-specific files, or maybe completely a function of the WU. It's OK if we create lots of images. In general they'll share most of their layers so there's no disk penalty.
Remove container and image at end of job User docker log to should output from container In standalone mode, slot dir is . and project is project/ Add some verbose output; send all debugging output to stderr
We don't use Docker Desktop. Instead we use a WSL Ubuntu 24.04 image in which podman is installed.
Either or both could be present on both Linux and Win/WSL.
If both, use podman.
Do this separately for engine and compose;
a host could have the podman engine but Docker compose.
data structures:
old: (in both HOSTINFO and WSL_DISTRO):
bool is_docker_available: it's present, AND allowed by config
string docker_version
... and same for docker_compose
new:
string docker_version: empty if not present
DOCKER_TYPE docker_version_type (DOCKER or PODMAN)
We send this in sched requests even if Docker disallowed by prefs
(send that flag separately).
This way projects can know what software a host has,
even if they can't use it.
(Should use this approach with VBox too)
… requests. (still query the presence of docker, and report it in sched requests). scheduler: parse the above docker_wrapper: use either docker or podman, depending on what's there (on the host (Unix) or in a WSL distro (Win))
use pause/unpause instead of start/stop Note: this works with podman only if root; need to figure out how to do that
needed for podman's pause and unpause to work Add a lib function run_command_pipe() for this purpose.
|
@davidpanderson, please fix build error: https://github.com/BOINC/boinc/actions/runs/11507373201/job/32033412490?pr=5855 |
This was
linked to
issues
Oct 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5855 +/- ##
============================================
+ Coverage 10.51% 10.76% +0.25%
Complexity 1068 1068
============================================
Files 280 280
Lines 36021 36493 +472
Branches 8441 8444 +3
============================================
+ Hits 3789 3930 +141
- Misses 31843 32174 +331
Partials 389 389
|
|
Done |
AenBleidd
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support app versions that run jobs in Docker containers.
This also works with podman, an open-source and daemonless Docker equivalent.
Also: some changes to the client in terms of how Docker and podman are detected,
and the corresponding data structures.
Also: minor changes to the scheduler for parsing this info
(to be used by plan class specs).
Fixes #5825