Mac: Fix build break introduced by commit 8ea2aba1d8 #5370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 21, 2023 02:06
Remove app_test.cpp from build of switcher
… so CI builds will detect problems building them
|
@davidpanderson I don't understand why you added app_test.cpp to the switcher target. But remember that you must never edit the Xcode project file directly using a text editor. It must be modified only using Xcode. |
|
This PR is ready to be merged when the CI checks finish. |
AenBleidd
approved these changes
Sep 21, 2023
|
I added it using xcode, but I guess I got it wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove app_test.cpp from build of switcher
Also, add switcher and setprojectgrp targets as dependencies to client so CI builds will detect problems building them.