Mgr: Offer only languages for which we have translations #5332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before BOINC 7.24.0, the Other Options dialog offered users all 897 languages and language variants possibly supported by wxWidgets. PR #5176 reduced this number by eliminating those for which we don't have a reasonable substitute translation for the requested language variant. For example, if the user selected the French dialect spoken in Chad (ISO language code
fr_TD
), BOINC substitutes generic French (ISO codefr
); so the dialog offeredfr_TD
even though it would actually provide a generic French translation.This is still an unwieldy number of choices and gives the false impression that BOINC actually provides all the listed dialects. This PR modifies the code to offer only the language dialects for which we provide actual translations. For backward compatibility, if the user had selected a dialect not in the new list while running an earlier version of BOINC, that dialect will continue to be listed.
In addition, this change makes it possible for me to make the improvement I unsuccessfully tried to implement in PR #5329: Compare best translations for selected languages.
@AenBleidd and @BrianNixon please tell me what you think.
Here is how the new trimmed language selection dialog looks now on the Mac: