Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA-3806: Change request filters bug #1910

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hakifran
Copy link
Contributor

@hakifran hakifran commented Jan 10, 2025

What problem is this PR solving? Explain here in one sentence.

Related JIRA tickets : IA-3806

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Doc

Tell us where the doc can be found (docs folder, wiki, in the code...).

Changes

  • Reset params and filters on groups

How to test

  • Filters on groups, dataSource and source_versions

Print screen / video

Screencast.from.2025-01-10.10-18-52.webm

Notes

Things that the reviewers should know:

  • known bugs that are out of the scope of the PR
  • other trade-offs that were made
  • does the PR depends on a PR in bluesquare-components?
  • should the PR be merged into another PR?

Follow the Conventional Commits specification

The merge message of a pull request must follow the Conventional Commits specification.

This convention helps to automatically generate release notes.

Use lowercase for consistency.

Example:

fix: empty instance pop up

Refs: IA-3665

Note that the Jira reference is preceded by a line break.

Both the line break and the Jira reference are entered in the Add an optional extended description… field.

@hakifran hakifran marked this pull request as ready for review January 10, 2025 08:21
@hakifran hakifran requested a review from quang-le January 10, 2025 08:22
@hakifran
Copy link
Contributor Author

@quang-le I made some changes, you can check if it is good and approve it. thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant