Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POLIO-1814: remove deprecated merged shapes endpoints #1908

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

quang-le
Copy link
Member

@quang-le quang-le commented Jan 9, 2025

What problem is this PR solving? Explain here in one sentence.

Related JIRA tickets : POLIO-1814

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Doc

Added a docstring on the method

Changes

  • Delete api/polio/campaigns/merged_shapes.geojson/
  • Delete api/polio/campaigns/v2/merged_shapes.geojson/
  • Add comment to the remaining v3 endpoint
  • Remove obsolete test

How to test

Go to polio calendar and embedded calendar. Nothing should change, in particular, the merged campaign shgapes (displayed by default) should still be there

Print screen / video

NA

Follow the Conventional Commits specification

The merge message of a pull request must follow the Conventional Commits specification.

This convention helps to automatically generate release notes.

Use lowercase for consistency.

Example:

fix: empty instance pop up

Refs: IA-3665

Note that the Jira reference is preceded by a line break.

Both the line break and the Jira reference are entered in the Add an optional extended description… field.

- Delete api/polio/campaigns/merged_shapes.geojson/
- Delete api/polio/campaigns/v2/merged_shapes.geojson/
- Add comment to the remaining v3 endpoint
- Remove obsolete test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant