POLIO-1774: delete rounds without campaign #1906
Open
+154
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add method to make sure RoundScope and associated Group are deleted as well - Add tests
kemar
requested changes
Jan 9, 2025
| which happens when a Round is deleted. | ||
| """ | ||
| if instance.group: | ||
| instance.group.delete() |
There was a problem hiding this comment.
There is a rule of thumb with signals: use them as a last resort.
The reason is that after adding a bunch of signals, projects start to turn into knotted hairballs that can't be untangled.
Do you think it would be possible to move this either into RoundScope.delete() or in a custom model manager method?
Otherwise, let's move it into a proper signals.py file to make it obvious and easy to spot.
| cls.source_version, | ||
| cls.ou_type_country, | ||
| cls.ou_type_district, | ||
| "GROLAND", |
There was a problem hiding this comment.
Is this better than "Hydroponic gardens"? 🤣
There was a problem hiding this comment.
Totally, and this is a hill I'm ready to die on 😁
More seriously, the name field don't matter that much as long as the variable/property is correctly named , I think
| @@ -26,7 +26,7 @@ def setUpTestData(cls): | |||
| cls.now = now() | |||
| cls.source_version_1 = m.SourceVersion.objects.create(data_source=cls.data_source, number=1) | |||
| cls.account = polio_account = Account.objects.create(name="polio", default_version=cls.source_version_1) | |||
| cls.yoda = cls.create_user_with_profile(username="yoda", account=polio_account, permissions=["iaso_forms"]) | |||
| cls.user = cls.create_user_with_profile(username="yoda", account=polio_account, permissions=["iaso_forms"]) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polio had rounds without campaign, which shouldn't be possible
Related JIRA tickets : POLIO-1774
Self proofreading checklist
Doc
NA
Changes
RoundScopeand associatedGroupare deleted as well when aRoundis deletedHow to test
In the UI:
Alternately, you can check directly on the DB
Print screen / video
N/A
Follow the Conventional Commits specification
The merge message of a pull request must follow the Conventional Commits specification.
This convention helps to automatically generate release notes.
Use lowercase for consistency.
Example:
Note that the Jira reference is preceded by a line break.
Both the line break and the Jira reference are entered in the Add an optional extended description… field.