-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IA-3783 bulk push of gps from submissions to org unit [frontend] #1891
Merged
hakifran
merged 73 commits into
IA-3667_push-bulk-gps-from-instances
from
IA-3783-Bulk-push-of-gps-from-submissions-to-OUs-frontend
Jan 9, 2025
Merged
IA-3783 bulk push of gps from submissions to org unit [frontend] #1891
hakifran
merged 73 commits into
IA-3667_push-bulk-gps-from-instances
from
IA-3783-Bulk-push-of-gps-from-submissions-to-OUs-frontend
Jan 9, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the bulk gps check in order to call it inside the task. Fixed typo in HasCreateOrgUnitPermission.
tdethier
changed the base branch from
main
to
IA-3667_push-bulk-gps-from-instances
December 20, 2024 14:33
tdethier
force-pushed
the
IA-3783-Bulk-push-of-gps-from-submissions-to-OUs-frontend
branch
from
January 2, 2025 12:09
c5b85e0
to
f6c5ae4
Compare
hakifran
force-pushed
the
IA-3783-Bulk-push-of-gps-from-submissions-to-OUs-frontend
branch
from
January 2, 2025 12:49
f6c5ae4
to
b13ae85
Compare
Refactored the bulk gps check in order to call it inside the task. Fixed typo in HasCreateOrgUnitPermission.
tdethier
force-pushed
the
IA-3783-Bulk-push-of-gps-from-submissions-to-OUs-frontend
branch
from
January 7, 2025 15:41
f3c839b
to
6286b33
Compare
beygorghor
changed the title
Ia 3783 bulk push of gps from submissions to o us frontend
IA-3783 bulk push of gps from submissions to org unit: frontend
Jan 7, 2025
beygorghor
changed the title
IA-3783 bulk push of gps from submissions to org unit: frontend
IA-3783 bulk push of gps from submissions to org unit [frontend]
Jan 7, 2025
beygorghor
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is working nice for me ! just small remarks
hat/assets/js/apps/Iaso/domains/instances/hooks/useGetCheckBulkGpsPush.tsx
Outdated
Show resolved
Hide resolved
hat/assets/js/apps/Iaso/domains/instances/hooks/useInstanceBulkgpspush.tsx
Outdated
Show resolved
Hide resolved
hakifran
merged commit Jan 9, 2025
c38d678
into
IA-3667_push-bulk-gps-from-instances
3 checks passed
hakifran
deleted the
IA-3783-Bulk-push-of-gps-from-submissions-to-OUs-frontend
branch
January 9, 2025 10:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR solving? Explain here in one sentence.
Related JIRA tickets : IA-3783
Self proofreading checklist
Doc
Tell us where the doc can be found (docs folder, wiki, in the code...).
Changes
How to test
Print screen / video
Screencast from 2025-01-07 15-56-49.webm
Screencast from 2025-01-07 15-59-07.webm
Upload here print screens or videos showing the changes.
Notes
Things that the reviewers should know:
Follow the Conventional Commits specification
The merge message of a pull request must follow the Conventional Commits specification.
This convention helps to automatically generate release notes.
Use lowercase for consistency.
Example:
Note that the Jira reference is preceded by a line break.
Both the line break and the Jira reference are entered in the Add an optional extended description… field.