Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA-3783 bulk push of gps from submissions to org unit [frontend] #1891

Conversation

hakifran
Copy link
Contributor

@hakifran hakifran commented Dec 20, 2024

What problem is this PR solving? Explain here in one sentence.

  • Bulk push of gps from submissions to OUs - frontend
    Related JIRA tickets : IA-3783

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Doc

Tell us where the doc can be found (docs folder, wiki, in the code...).

Changes

  • Add a push bulk gps from submission to orgUnit

How to test

  • Select multiple submissions
  • Go to actions
  • Select Push gps from submissions to orgUnits

Print screen / video

Screencast from 2025-01-07 15-56-49.webm
Screencast from 2025-01-07 15-59-07.webm

Upload here print screens or videos showing the changes.

Notes

Things that the reviewers should know:

  • known bugs that are out of the scope of the PR
  • other trade-offs that were made
  • does the PR depends on a PR in bluesquare-components?
  • should the PR be merged into another PR?

Follow the Conventional Commits specification

The merge message of a pull request must follow the Conventional Commits specification.

This convention helps to automatically generate release notes.

Use lowercase for consistency.

Example:

fix: empty instance pop up

Refs: IA-3665

Note that the Jira reference is preceded by a line break.

Both the line break and the Jira reference are entered in the Add an optional extended description… field.

@tdethier tdethier changed the base branch from main to IA-3667_push-bulk-gps-from-instances December 20, 2024 14:33
@tdethier tdethier force-pushed the IA-3783-Bulk-push-of-gps-from-submissions-to-OUs-frontend branch from c5b85e0 to f6c5ae4 Compare January 2, 2025 12:09
@hakifran hakifran force-pushed the IA-3783-Bulk-push-of-gps-from-submissions-to-OUs-frontend branch from f6c5ae4 to b13ae85 Compare January 2, 2025 12:49
@tdethier tdethier force-pushed the IA-3783-Bulk-push-of-gps-from-submissions-to-OUs-frontend branch from f3c839b to 6286b33 Compare January 7, 2025 15:41
-Bulk-push-of-gps-from-submissions-to-OUs-frontend
@beygorghor beygorghor changed the title Ia 3783 bulk push of gps from submissions to o us frontend IA-3783 bulk push of gps from submissions to org unit: frontend Jan 7, 2025
@beygorghor beygorghor changed the title IA-3783 bulk push of gps from submissions to org unit: frontend IA-3783 bulk push of gps from submissions to org unit [frontend] Jan 7, 2025
Copy link
Collaborator

@beygorghor beygorghor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is working nice for me ! just small remarks

@beygorghor beygorghor added the release Should be released in production at next deploy label Jan 9, 2025
@hakifran hakifran merged commit c38d678 into IA-3667_push-bulk-gps-from-instances Jan 9, 2025
3 checks passed
@hakifran hakifran deleted the IA-3783-Bulk-push-of-gps-from-submissions-to-OUs-frontend branch January 9, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Should be released in production at next deploy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants