-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IA-3728 Create change requests from differences between two pyramids (backend model) #1836
Open
kemar
wants to merge
57
commits into
main
Choose a base branch
from
IA-3728-create-change-requests-from-differences-between-two-pyramids
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
IA-3728 Create change requests from differences between two pyramids (backend model) #1836
kemar
wants to merge
57
commits into
main
from
IA-3728-create-change-requests-from-differences-between-two-pyramids
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemar
force-pushed
the
IA-3728-create-change-requests-from-differences-between-two-pyramids
branch
from
December 5, 2024 12:23
7332ea4
to
778f5de
Compare
kemar
force-pushed
the
IA-3728-create-change-requests-from-differences-between-two-pyramids
branch
from
December 17, 2024 15:52
81609c3
to
1c8eda3
Compare
kemar
changed the title
IA-3728 Create change requests from differences between two pyramids (backend)
IA-3728 Create change requests from differences between two pyramids (backend model)
Dec 31, 2024
… use `DjangoJSONEncoder`
kemar
force-pushed
the
IA-3728-create-change-requests-from-differences-between-two-pyramids
branch
from
December 31, 2024 09:36
d9cbcde
to
2a6d078
Compare
…er than with `bytes`
madewulf
reviewed
Jan 2, 2025
…the parameters used for the diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create change requests from differences between two pyramids (backend model).
Related JIRA tickets : IA-3728
Doc
See the design specification linked in the aforementioned JIRA ticket.
Changes
new
DataSourceSynchronization
model and admin:diffing
module for the logicdiffing
module:Dumper.dump_as_json()
which was brokenDiffer.diff
for groups (only groups from one side were taken into account)Differ.compare_fields
if dhis2_value is None and ref_value is not None:
wasn't working whenref_value = []
(empty list) for empty groupsHow to test
go to
/admin/iaso/datasourceversionssynchronization/add/
configure a new "Data source synchronization" with two source versions that you want to synchronize
save
find the ID of the newly created "Data source synchronization"
open a Django shell
docker compose exec -ti iaso ./manage.py shell_plus
trigger the synchronization (those steps will be handled by the future API):
get the "Data source synchronization" object assuming its ID is
1
:generate the diff between the two pyramids (this allows to count how many change requests there will be):
synchronize the two pyramids and create "change requests":
go to
/admin/iaso/orgunitchangerequest/
filter the list by your "Data source synchronization"
you should be able to see the newly created "change requests"
Print screen